Hello Stefan,
On 04/24/2015 09:27 PM, Stefan Agner wrote:
The ethernet gadget driver requires the hex formatted MAC address
bytes with leading zero, in other words each byte needs to be two
characters in length (see get_ether_addr in u_ether.c). The libc
implementation ether_ntoa does not print leading zeros. Hence use
our own implementation which provides the format expected by the
kernel.
Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
Reviewed-by: Krzysztof Opasiak <k.opasiak@xxxxxxxxxxx>
Thank you for your patch. Very good catch. I haven't noticed this
earlier. In my opinion kernel should accept MAC address without leading
0 so I have prepared a patch with this[1]. But of course for
compatibility with older kernels your commit should be applied.
Together with a few other libusbg community members we continue
development in my github repo[2]. As we are almost 100 commits ahead I
had to rebase your patch with some changes before applying it to my
tree. That's why you will find my signoff instead of reviewed-by on your
commit in my tree[3].
Footnotes:
1 - http://article.gmane.org/gmane.linux.usb.general/125080
2 - https://github.com/kopasiak/libusbg
3 -
https://github.com/kopasiak/libusbg/commit/93631e618436989ebd7e9df2c997c175feb14bda
Best regards,
--
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
