Re: [PATCHv2 2/3] usb: ehci-platform: Use devm_of_phy_get_by_index

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Arnd,

On Wednesday 15 April 2015 03:17 AM, Arnd Bergmann wrote:
On Tuesday 14 April 2015 11:05:35 Arun Ramamurthy wrote:

[1] ->
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/kbuild/kconfig-language.txt#n111

Kishon,removing select GENERIC_PHY also breaks the builds for certain
architectures (i386 and x84_64). Is the consensus to leave the select
but make GENERIC_PHY a invisible option? Thanks

I think the best solution is

- make GENERIC_PHY a silent option
- change PHY_RCAR_GEN2 to use 'select' instead of 'depends on', so
   it will still work when all other phy drivers are disabled
- change the non-phy drivers that select GENERIC_PHY to either
   use 'depends on' or no explicit dependency in case they are
   still functional without the API. Note that
   drivers/pinctrl/pinctrl-tegra-xusb.c is a phy provider as well,
   not a consumer, despite being outside of drivers/phy.

makes sense to me.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux