usb: gadget: f_fs: O_NONBLOCK waits MAX_SCHEDULE_TIMEOUT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I have been looking at an issue where a phone that is the Function FS
host sometimes locks up and causes the function:
static ssize_t ffs_epfile_io(struct file *file, struct ffs_io_data
*io_data) in drivers/usb/gadget/function/f_fs.c to timeout after
MAX_SCHEDULE_TIMEOUT jiffies.

We are opening the ffs connection with the O_NONBLOCK option and this
timeout seems to be far too long.

The code causing the wait is here (line 834):

if (unlikely(ret < 0)) {
    /* nop */
} else if (unlikely(
        wait_for_completion_interruptible(&done))) {
    ret = -EINTR;
    usb_ep_dequeue(ep->ep, req);
} else {

The function call wait_for_completion_interruptible(&done) equates to:
wait_for_completion_interruptible_timeout(&done, MAX_SCHEDULE_TIMEOUT);


I was wondering what to change to fix this, is it reasonable to use a
very small timeout if it is O_NONBLOCK or is any blocking not allowed?

I would appreciate any thoughts on how this should work?

Thank you,
Jim
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux