Re: [PATCH v4 0/8] add HNP polling support for usb otg fsm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 25, 2015 at 07:25:24PM +0800, Li Jun wrote:
> On Wed, Mar 25, 2015 at 02:43:43PM +0800, Chen Peter-B29397 wrote:
> >  
> > > On Wed, Mar 25, 2015 at 02:03:51PM +0800, Peter Chen wrote:
> > > >
> > > > Hi Jun,
> > > >
> > > > The above three patches are in Greg's next tree, after I apply your
> > > > chipidea fix [1] for pullup dp, it still some other problems for HNP,
> > > > am I missing something?
> > > >
> > > > The procedures to reproduce:
> > > >
> > > > - Connect USB cable and MicroAB cable between two boards
> > > > - Boot up two boards
> > > > - load g_mass_storage at B-device side, the enumeration will success,
> > > > and A will see a usb mass-storage device
> > > > - load g_mass_storage at A-device side
> > > > - Do HNP at B side, the HNP will succeed echo 1 >
> > > > /sys/bus/platform/devices/ci_hdrc.0/inputs/b_bus_req
> > > > - Do HNP at A side
> > > > echo 1 > /sys/bus/platform/devices/ci_hdrc.0/inputs/a_bus_req
> > > >
> > > > The problem has occurred, the A can't be back to host again.
> > > >
> > > I use your peter-usb-dev branch and did not found the problem, so I need use
> > > Greg's tree to try again?
> > > 
> > 
> > No, I first found this problem with my dev tree, then, I rebase the latest Greg next
> > tree, this problem still exists.  You can try to use FSL imx6dl sdb as A device and imx6sx sdb
> > as B device to reproduce it.
> > 
> 
> It can work with my i.MX6DL + i.MX6Q SD, but with i.MX6DL + i.MX6SX SDB, I can
> reproduce the problem you reported, which triggers a bug in our otg_fsm driver,
> I will send out a patch to fix it.
> 
> Li Jun
> 

Jun,

With your two chipidea fixes [1][2], I can run otg test successfully.

[1]
https://git.kernel.org/cgit/linux/kernel/git/peter.chen/usb.git/commit/?h=ci-for-usb-stable&id=885510e8778bf0f2d38e2fd0807d8f84ca12a8d9
[2]
https://git.kernel.org/cgit/linux/kernel/git/peter.chen/usb.git/commit/?h=ci-for-usb-next&id=80c4b00dd0bee2ff5f430fae7e96d9599d36682f

Hi Felipe,

I am ok with this series, if you have no more comments, would you help
queue this series through your tree?

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux