Re: [PATCH v2] usb: introduce OTG 2.0 related kernel feature and API.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 26, 2015 at 11:21:43AM +0800, Macpaul Lin wrote:
> Introduce kernel feature CONFIG_USB_OTG20 and related
> gadget_is_otg20() API for supporting OTG20 compliant
> drivers.
> This patch also updated usb_otg_descritpor.
> 
> Signed-off-by: Macpaul Lin <macpaul@xxxxxxxxx>
> ---
>  drivers/usb/core/Kconfig     |  9 +++++++++
>  include/linux/usb/gadget.h   | 24 ++++++++++++++++++++++++
>  include/uapi/linux/usb/ch9.h |  4 ++++
>  3 files changed, 37 insertions(+)
> 
> changes for v2:
>  - Add USB_OTG_ADP definition in ch9.h
> 
> diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig
> index cc0ced0..7fdda5f 100644
> --- a/drivers/usb/core/Kconfig
> +++ b/drivers/usb/core/Kconfig
> @@ -55,6 +55,15 @@ config USB_OTG
>  	  Select this only if your board has Mini-AB/Micro-AB
>  	  connector.
>  
> +config USB_OTG20
> +	bool "OTG20 support (EXPERIMENTAL)"

The "EXPERIMENTAL" tag is no longer used, please remove.

> +	depends on USB_OTG
> +	default n

That's the normal default, please remove.

> +	help
> +	  This feature is still under developing.
> +
> +	  Select this only if your board support OTG 20's hardware requirements.

Please provide more information here, and a '.'  Why would someone want
to turn this off?  What is "OTG"?  Be specific here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux