Re: [PATCH 4/4] usb: legacy/multi add supports OTG 2.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 26, 2015 at 03:38:38AM +0800, Macpaul Lin wrote:
> add supports OTG 2.0 for multi.c
> 
> Signed-off-by: Macpaul Lin <macpaul@xxxxxxxxx>
> ---
>  drivers/usb/gadget/legacy/multi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/gadget/legacy/multi.c b/drivers/usb/gadget/legacy/multi.c
> index 39d27bb..0f4005e 100644
> --- a/drivers/usb/gadget/legacy/multi.c
> +++ b/drivers/usb/gadget/legacy/multi.c
> @@ -89,6 +89,9 @@ static const struct usb_descriptor_header *otg_desc[] = {
>  		 * it would not be called "OTG" ...
>  		 */
>  		.bmAttributes =		USB_OTG_SRP | USB_OTG_HNP,

After you introduce some flags for controller to decide if HNP/SRP/ADP can be
supported, this setting in all gadget drivers should be override according to those
flags too, otherwise there will be possible mismatch between the OTG descriptor
within config(like above setting) and the response for getting OTG descriptor
request(your patch 3 does in composite.c).

Li Jun
> +#ifdef	CONFIG_USB_OTG20
> +		.bcdOTG =		cpu_to_le16(0x0200),
> +#endif
>  	},
>  	NULL,
>  };
> -- 
> 1.8.3.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux