On Thu, 19 Mar 2015, Thomas Petazzoni wrote: > These are indeed all valid concerns. However, as you can see, those > concerns are completely orthogonal to the patch: the original code > already has those issues. Quite true. You may add Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> to the v2 patch. > Regarding the addition of a timeout, I unfortunately have absolutely no > idea what would be the a proper timeout value at this place. I quickly > glanced through > http://www.intel.com/content/dam/www/public/us/en/documents/technical-specifications/ehci-specification-for-usb.pdf > for the documentation of this reset bit, but couldn't spot a maximum > accepted duration for the operation. ehci-hcd uses 250 ms. This seems to be an arbitrary value, but at least it's better than hanging the system. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
