RE: [PATCH v1 00/20] usb: third series of updates for dwc2 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: John Youn [mailto:John.Youn@xxxxxxxxxxxx]
> Sent: Wednesday, March 18, 2015 3:33 AM
> To: Kaukab, Yousaf; linux-usb@xxxxxxxxxxxxxxx; balbi@xxxxxx;
> john.youn@xxxxxxxxxxxx
> Cc: Herrero, Gregory; r.baldyga@xxxxxxxxxxx;
> dinguyen@xxxxxxxxxxxxxxxxxxxxx; zhangfei.gao@xxxxxxxxxx
> Subject: Re: [PATCH v1 00/20] usb: third series of updates for dwc2 driver
> 
> On 3/17/2015 2:54 AM, Mian Yousaf Kaukab wrote:
> > Hi,
> > This patchset consists of some bug fixes and feature enhancements for
> > the dwc2 driver. All the patches are verified on dwc2 v3.0a with
> > dedicated fifos. Main focus of testing was with dma enabled. Although
> > basic testing without dma was also done.
> >
> > This is based on testing/next branch in Felipe's git.
> >
> > Thank you,
> >
> > Best regards,
> > Yousaf
> >
> 
> Hi Yousaf,
> 
> Patch 15 and 16 introduce regressions in two systems that I tested with.

:( sorry for that. I will try to fix this asap.

> 
> After patch 15, the host fails to work at all.

My understanding is that functionality can break within the patchset but it should build at any point. If that's not correct, is merging patch 15 and 16 OK for you?

> 
> After patch 16, the host works but the device fails enumeration whenever
> switching from an A to B cable, going from host to peripheral. After this fails, if
> you unplug and replug the B cable it will enumerate. But whenever you switch
> from A to B it always fails.
> 
> Tested on a Synopsys (2.94a) and Altera (2.93a) system.
> 
> I don't have any logs right now but I can get those tomorrow if you need them.

It will be very helpful if you can provide log after CONFUG_USB_DWC2_DEBUG enabled and also function trace of dwc2 driver.

> 
> John
> 

And thank you for other comments. I have fixed all of them. I will send the next revision as soon as we find a fix for the regression you mentioned.

BR,
Yousaf
��.n��������+%������w��{.n�����{���)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux