Re: keyspan_pda.c "new" device ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 16, 2015 at 04:25:06AM -0400, Nathaniel W Filardo wrote:
> Add USB VID/PID for Xircom PGMFHUB USB/serial component.  (The hub and SCSI
> bridge on that hardware are recognized out of the box by existing drivers.)
> Tested VID/PID using new_id and loopback connection and was met with
> success, but that's all the testing done.

Patch looks good, but can you resend with a more descriptive commit
message (Subject) including the subsystem, for example:

	"[PATCH] USB: keyspan_pda: add new device id"

> Signed-Off-By: Nathaniel Wesley Filardo <nwf@xxxxxxxxxx>

scripts/checkpatch.pl is also complaining about you Signed-off-by tag
(use lowercase letters for Off-By).

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux