On Sun, Mar 15, 2015 at 07:35:20AM +0100, Alexander Holler wrote: > > Umm... If I'm not misparsing what you said, you are talking about the > > Glücklicherweise nicht. Vielleicht sollten wir es zur Abwechslung mal > mit meiner bevorzugten Sprache versuchen. Good. I'll probably abstain from trying to mangle it, though. Another question, if you don't mind - does that series (i.e. what's currently in Linus' tree) fix the module refcount issues you'd been seeing? I agree with your analysis of likely cause (->f_op reassignments with different ->owner before and after) and these patches should have eliminated that, but confirmation would be nice... Incidentally, none of those file_operations need ->owner in the first place; it doesn't hurt (as long as ->f_op doesn't change that way), but such files (living on a filesystem provided by the module their methods are in) don't need the module refcount bumped while the file is opened - having it opened pins file_system_type of containing filesystem (by keeping a reference to struct vfsmount, which keeps a reference to struct super_block, which keeps a reference to file_system_type), so the module will be kept busy just fine. Again, having ->owner on file_operations doesn't hurt, so it's not a bug per se - just pointless in such cases. So we might want to remove it from ep_io_operations someday. Anyway, that's a completely separate story... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
