Re: [PATCH 2/8][v2]usb:fsl:otg: Add support to add/remove usb host driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 13, 2015 at 01:57:54PM -0500, Felipe Balbi wrote:
> On Fri, Mar 13, 2015 at 11:41:09PM +0530, Ramneek Mehresh wrote:
> > Add workqueue to add/remove host driver (outside interrupt context)
> > upon each id change
> > 
> > Signed-off-by: Li Yang <leoli@xxxxxxxxxxxxx>
> > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@xxxxxxxxxxxxx>
> > Reviewed-by: Fleming Andrew-AFLEMING <AFLEMING@xxxxxxxxxxxxx>
> > Tested-by: Fleming Andrew-AFLEMING <AFLEMING@xxxxxxxxxxxxx>
> > ---
> > Changes for v2:
> > 	- moved change_hcd_work into struct ehci_fsl
> > 
> >  drivers/usb/host/ehci-fsl.c   | 107 ++++++++++++++++++++++++++++++++++--------
> >  drivers/usb/host/ehci.h       |   1 -
> >  drivers/usb/phy/phy-fsl-usb.c |   7 ++-
> 
> you really ought to find a way to split this patch so that phy-fsl-usb.c
> and ehci changes don't depend on each other. That way I can take the phy
> part through my tree while Alan handles EHCI.

you see, you *just* sent your patch and I reviewed it as soon as
possible. Even though you sent *only* this patch and not as a reply to
the original. If you're going to send it again, either send the entire
series as a new thread, or send the new revision for that patch as a
reply to original. How do you expect maintainers to track your patches
otherwise ? By bothering them with private emails linking to older
versions of your patches ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux