Re: [PATCH] usb: musb: dsps: request phy using our device pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Tony Lindgren <tony@xxxxxxxxxxx> [150311 08:48]:
> * Felipe Balbi <balbi@xxxxxx> [150311 08:20]:
> > musb shouldn't have of_node and phy phandle is passed
> > to dsps device, not musb's.
> 
> Reported-by: Tony Lindgren <tony@xxxxxxxxxxx>

Oops, sorry wrong patch, looks like you already have it
in the patch I was thinking. Never mind.

Tony
  
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> >  drivers/usb/musb/musb_dsps.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c
> > index baa757ba1353..a528d3be70c5 100644
> > --- a/drivers/usb/musb/musb_dsps.c
> > +++ b/drivers/usb/musb/musb_dsps.c
> > @@ -432,7 +432,7 @@ static int dsps_musb_init(struct musb *musb)
> >  	musb->ctrl_base = reg_base;
> >  
> >  	/* NOP driver needs change if supporting dual instance */
> > -	musb->xceiv = devm_usb_get_phy_by_phandle(dev, "phys", 0);
> > +	musb->xceiv = devm_usb_get_phy_by_phandle(dev->parent, "phys", 0);
> >  	if (IS_ERR(musb->xceiv))
> >  		return PTR_ERR(musb->xceiv);
> >  
> > -- 
> > 2.3.0
> > 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux