* Kishon Vijay Abraham I <kishon@xxxxxx> [150311 02:58]:
> Hi Tony,
>
> On Tuesday 10 March 2015 02:21 AM, Tony Lindgren wrote:
> >Add a minimal driver for dm816x USB. Otherwise we can just use
> >the existing musb_am335x and musb_dsps on dm816x.
>
> If we can use an existing driver, I'd prefer that.
Hmm that needs rewording.. Should say that with this phy
driver musb works with existing musb_dsps usb driver on
dm816x. There is no existing driver, the closest similar
thing is the legacy drivers/usb/musb/davinci.c that has
no separate phy driver.
> >+static int dm816x_usb_phy_power_off(struct phy *x)
> >+{
> >+ struct dm816x_usb_phy *phy = phy_get_drvdata(x);
> >+
> >+ pm_runtime_put(phy->dev);
>
> phy core takes care of invoking pm_runtime_put on power_off.
> So this function shouldn't be needed at all.
OK will remove the pm_runtime calls for all of them.
...
> >+ phy->refclk = devm_clk_get(phy->dev, "refclk");
> >+ if (IS_ERR(phy->refclk))
> >+ return PTR_ERR(phy->refclk);
> >+
> >+ generic_phy = devm_phy_create(phy->dev, NULL, &ops);
> >+ if (IS_ERR(generic_phy))
> >+ return PTR_ERR(generic_phy);
>
> Just invoke pm_runtime_enable before phy_create and phy core will take care of
> invoking all pm_runtime functions at appropriate time.
OK will.
Thanks,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
