On Tue, Mar 10, 2015 at 04:18:47PM -0500, Felipe Balbi wrote: > On Sun, Feb 15, 2015 at 03:39:48PM +0800, Peter Chen wrote: > > We should signal connect (pull up dp) after we have already > > at peripheral mode, otherwise, the dp may be toggled due to > > we reset controller or do disconnect during the initialization > > for peripheral, then, the host may be confused during the > > enumeration, eg, it finds the reset can't succeed, but the > > device is still there, see below error message. > > > > hub 1-0:1.0: USB hub found > > hub 1-0:1.0: 1 port detected > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: Cannot enable port 1. Maybe the USB cable is bad? > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: Cannot enable port 1. Maybe the USB cable is bad? > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: Cannot enable port 1. Maybe the USB cable is bad? > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: cannot reset port 1 (err = -32) > > hub 1-0:1.0: Cannot enable port 1. Maybe the USB cable is bad? > > hub 1-0:1.0: unable to enumerate USB device on port 1 > > > > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> > > when was this introduced ? Do you want to Cc stable ? > When this fsm code was added at the first time, thanks, I will cc to stable at next version. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
