Re: [PATCH v3] usb: phy: phy-generic: No need to call gpiod_direction_output() twice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2015 at 06:22:17PM -0300, Fabio Estevam wrote:
> On Tue, Mar 10, 2015 at 6:20 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> > On Tue, Feb 03, 2015 at 07:18:17PM -0200, Fabio Estevam wrote:
> >> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> >>
> >> Commit 9eb0797722895f4309b4 ("usb: phy: generic: fix the gpios to be optional")
> >> calls gpiod_direction_output() in the probe function, so there is no need to
> >> call it again, as we can simply call gpiod_set_value() directly.
> >>
> >> Also, in usb_gen_phy_shutdown() we can simply put the GPIO directly in its
> >> active level state and this allows us to simplify the nop_reset function to
> >> treat only the reset case.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> >
> > Is this for v4.1 or v4.0-rc ?
> 
> For 4.1, thanks

in my testing/next now, thanks

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux