RE: [PATCH 2/8][RESEND]usb:fsl:otg: Add support to add/remove usb host driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Alan Stern [mailto:stern@xxxxxxxxxxxxxxxxxxx]
> Sent: Tuesday, March 10, 2015 7:21 PM
> To: Mehresh Ramneek-B31383
> Cc: linux-usb@xxxxxxxxxxxxxxx; balbi@xxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; Li
> Yang-Leo-R58472
> Subject: Re: [PATCH 2/8][RESEND]usb:fsl:otg: Add support to add/remove
> usb host driver
> 
> On Tue, 10 Mar 2015, Ramneek Mehresh wrote:
> 
> > Add workqueue to add/remove host driver (outside interrupt context)
> > upon each id change
> 
> > --- a/drivers/usb/host/ehci.h
> > +++ b/drivers/usb/host/ehci.h
> > @@ -177,7 +177,9 @@ struct ehci_hcd {			/* one per
> controller */
> >  	unsigned		periodic_count;	/* periodic activity
> count */
> >  	unsigned		uframe_periodic_max; /* max periodic time
> per uframe */
> >
> > -
> > +#if defined(CONFIG_FSL_USB2_OTG) ||
> defined(CONFIG_FSL_USB2_OTG_MODULE)
> > +	struct work_struct change_hcd_work;
> > +#endif
> 
> This belongs in the ehci_fsl structure, not ehci_hcd.  Or maybe in a generic
> OTG structure.
> 
Understood...let me try moving this into ehci_fsl 
Thanks.
> Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux