Re: [RFC PATCH] xhci: fix reporting of 0-sized URBs in control endpoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2 Mar 2015, Aleksander Morgado wrote:

> On Mon, Mar 2, 2015 at 6:10 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> >> On Mon, Mar 2, 2015 at 4:02 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> >> > On Mon, 2 Mar 2015, Aleksander Morgado wrote:
> >> >
> >> >> I think my patch also lacks the -EREMOTEIO return for the case when 0
> >> >> bytes are transferred. I'll try to update it today.
> >> >
> >> > It's not necessary.  The USB core automatically sets the status to
> >> > -EREMOTEIO if the status is equal to 0 and the transfer was short and
> >> > URB_SHORT_NOT_OK was set.  See __usb_hcd_giveback_urb()
> >>
> >> There are actually several places in xhci-ring.c where that check is
> >> done in order to return -EREMOTEIO; does that mean that all of them
> >> are redundant? e.g. not only the ones in process_ctrl_td() but also in
> >> finish_td().
> >
> > Yes, they are redundant.
> 
> I guess my v5 of the patch is still ok; right?

I didn't notice anything wrong with it.

> I can prepare a new
> patch to remove all the redundant -EREMOTEIO returns later.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux