On Fri, Feb 27, 2015 at 04:48:39PM +0100, Valentin Rothberg wrote: > On Fri, Feb 27, 2015 at 4:24 PM, Felipe Balbi <balbi@xxxxxx> wrote: > > On Fri, Feb 27, 2015 at 02:29:40PM +0100, Valentin Rothberg wrote: > >> The IRQF_DISABLED is a NOOP and scheduled to be removed. According to > >> commit e58aa3d2d0cc (genirq: Run irq handlers with interrupts disabled) > >> running IRQ handlers with interrupts enabled can cause stack overflows > >> when the interrupt line of the issuing device is still active. > >> > >> This patch removes using this deprecated flag and additionally removes > >> redundantly setting IRQF_SHARED. > > > > why is it redundant ? > > It's redundant in the call of isp1760_udc_register() as this function > sets the flag by requesting the IRQ. I mistakenly removed it also in > the call of isp1760_hcd_register() which does not alter the passed > irqflags. I will fix this in a second version of this patch. I am > sorry for this mistake. no problem, s**t happens ;) -- balbi
Attachment:
signature.asc
Description: Digital signature
