Re: [PATCH v2 11/15] usb: musb: core: controller drops session automatically

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe,

On Thu, Feb 26, 2015 at 12:25 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> Whenever babble happens, MUSB controller will
> drop session automatically.
>
> The only case where it won't drop the session,
> is when we're running on AM335x and SW_SESSION_CTRL
> bit has been set. In that case, controller will
> not touch session bit so SW has a chance to recover
> from babble condition.
>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
>  drivers/usb/musb/musb_core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index c3c5a6462600..70b2612205f8 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -879,8 +879,7 @@ b_host:
>                          * the session.
>                          */
>                         if (power & MUSB_POWER_HSMODE) {
> -                               ERR("Stopping host session -- babble\n");
> -                               musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> +                               ERR("Babble - session will be dropped\n");

Do you want to take this chance to change it to dev_err()?

>
>                                 if (is_host_active(musb)) {
>                                         musb_generic_disable(musb);
> --
> 2.3.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux