On Thu, Feb 26, 2015 at 06:37:17PM +0100, Michiel vdG wrote:
> These device ID's are not associated with the cp210x module currently,
> but should be. This patch allows the devices to operate upon
> connecting them to the usb bus as intended.
>
> Tested personally, reviewed by manufacturer
Thanks for the patch. Looks good, but there are a few minor issues:
The patch is line-wrapped and there are some leading spaces (instead of
tabs). Perhaps you need to fix your mailer or you could consider using
git send-email to send it. Have a look at git format-patch as well.
You need to add a Signed-off-by tag too.
There's more info in Documentation/SubmittingPatches.
Try sending the patch to yourself first and run scripts/checkpatch on it
before sending it to the list.
> diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
> index f40c856..cf372f0 100644
> --- a/drivers/usb/serial/cp210x.c
> +++ b/drivers/usb/serial/cp210x.c
> @@ -147,6 +147,8 @@ static const struct usb_device_id id_table[] = {
> { USB_DEVICE(0x166A, 0x0305) }, /* Clipsal C-5000CT2 C-Bus
> Spectrum Colour Touchscreen */
> { USB_DEVICE(0x166A, 0x0401) }, /* Clipsal L51xx C-Bus
> Architectural Dimmer */
> { USB_DEVICE(0x166A, 0x0101) }, /* Clipsal 5560884 C-Bus
> Multi-room Audio Matrix Switcher */
> + { USB_DEVICE(0x16C0, 0x09B0) }, /* Seletek */
> + { USB_DEVICE(0x16C0, 0x09B1) }, /* Seletek */
Please include the vendor name as well in the comment.
> { USB_DEVICE(0x16D6, 0x0001) }, /* Jablotron serial interface */
> { USB_DEVICE(0x16DC, 0x0010) }, /* W-IE-NE-R Plein & Baus GmbH
> PL512 Power Supply */
> { USB_DEVICE(0x16DC, 0x0011) }, /* W-IE-NE-R Plein & Baus GmbH
> RCM Remote Control for MARATON Power Supply */
Care to fix this up and send a v2?
Don't hesitate to ask if you have any questions.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
