Re: [PATCH v2 1/1] USB: ch341: set tty baud speed according to tty struct

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 19, 2015 at 11:43:27AM +0700, Johan Hovold wrote:
> On Wed, Feb 18, 2015 at 03:22:30PM -0500, Nicolas PLANEL wrote:
> > The ch341_set_baudrate() function initialize the device baud speed according
> > to the value on priv->baud_rate. By default the ch341_open() set it to a
> > hardcoded value (DEFAULT_BAUD_RATE 9600). Unfortunately, the tty_struct is
> > not initialized with the same default value. (usually 56700)
> > 
> > This means that the tty_struct and the device baud rate generator are not
> > synchronized after opening the port.
> > 
> > Fixup is done by calling ch341_set_termios() if tty exist.
> > Remove unnecessary variable priv->baud_rate setup as it's already done by ch341_port_probe().
> > 
> > Signed-off-by: Nicolas PLANEL <nicolas.planel@xxxxxxxxxxxx>
> 
> Thanks for the updated patch. I'll queue it up for 3.20 next week.

Hmm, this one doesn't even build. Did you not test your patch before
submitting it?

Please send a v3.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux