Hi Neil, On Tue, Feb 24, 2015 at 03:01:29PM +1100, NeilBrown wrote: > twl4030_charger currently finds the associated phy > using usb_get_phy() which will return the first USB2 phy. > If your platform has multiple such phys (as mine does), > this is not reliable (and reliably fails on the GTA04). > > Change to use devm_usb_get_phy_by_node(), having found the > node by looking for an appropriately named sibling in > device-tree. > > This makes usb-charging dependent on correct device-tree > configuration. The patch looks ok to me, but you should update the DT documentation in Documentation/devicetree/bindings/power/twl-charger.txt regarding the sibling dependency. Apart from that DT binding maintainers should be CC'd. -- Sebastian
Attachment:
signature.asc
Description: Digital signature
