On Mon, Feb 23, 2015 at 05:17:58AM -0700, Max Mansfield wrote:
> This patch integrates Cyber Cortex AV boards with the existing ftdi_jtag_quirk in order to
> use serial port 0 with JTAG which is required by the manufacturers' software.
>
> Steps: 2
>
> [ftdi_sio_ids.h]
> 1. Defined the device PID
>
> [ftdi_sio.c]
> 2. Added a macro declaration to the ids array, in order to enable the jtag quirk for the device.
Please break the commit-message lines at about 72 cols or so.
Also there are some whitespace issues below that you need to fix. Always
run scripts/checkpatch.pl on your patches before submitting.
> Signed-off-by: Max Mansfield <max.m.mansfield@xxxxxxxxx>
> ---
> drivers/usb/serial/ftdi_sio.c | 2 ++
> drivers/usb/serial/ftdi_sio_ids.h | 6 ++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
> index 1ebb351..733524d 100644
> --- a/drivers/usb/serial/ftdi_sio.c
> +++ b/drivers/usb/serial/ftdi_sio.c
> @@ -807,6 +807,8 @@ static const struct usb_device_id id_table_combined[] = {
> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> { USB_DEVICE(FTDI_VID, FTDI_OOCDLINK_PID),
> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> + { USB_DEVICE(FTDI_VID, CYBER_CORTEX_AV_PID),
> + .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> { USB_DEVICE(FTDI_VID, LMI_LM3S_DEVEL_BOARD_PID),
> .driver_info = (kernel_ulong_t)&ftdi_jtag_quirk },
> { USB_DEVICE(FTDI_VID, LMI_LM3S_EVAL_BOARD_PID),
> diff --git a/drivers/usb/serial/ftdi_sio_ids.h b/drivers/usb/serial/ftdi_sio_ids.h
> index e52409c..9a88f32 100644
> --- a/drivers/usb/serial/ftdi_sio_ids.h
> +++ b/drivers/usb/serial/ftdi_sio_ids.h
> @@ -69,6 +69,12 @@
> * (http://www.joernonline.de/) */
> #define FTDI_OOCDLINK_PID 0xbaf8 /* Amontec JTAGkey */
>
> +/* Cyber Cortex AV by Fabulous Silicon (http://fabuloussilicon.com)
> + * USB 0: CorePack [JTAG] idVendor: FTDI_VID (0x0403)
> + * USB 1: UART [USB] idProduct: CYBER_CORTEX_AV_PID (0x8698)
> + */
The preferred multi-line comment style is
/*
* ...
*/
You can also drop the ids from the comment.
> +#define CYBER_CORTEX_AV_PID 0x8698
> +
Please try to keep the entries sorted by PID here if possible (e.g. put
this entry before the MARVEL_PID in the same section.
> /* Luminary Micro Stellaris Boards, VID = FTDI_VID */
> /* FTDI 2332C Dual channel device, side A=245 FIFO (JTAG), Side B=RS232 UART */
> #define LMI_LM3S_DEVEL_BOARD_PID 0xbcd8
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
