> Greg KH <greg@xxxxxxxxx> hat am 17. Februar 2015 um 15:55 geschrieben: > > > On Tue, Feb 17, 2015 at 01:10:40PM +0100, Björn Gerhart wrote: > > Hello, > > > > in order to support an older USB cradle by Denso, I added its > > vendor- > > and product-ID to the array of usb_device_id acm_ids. In this way > > cdc-acm feels responsible for this cradle. The related /dev/ttyACM > > node is being created properly, and the data transfer works. > > > > However, later cradle models by Denso do have proper descriptors, so > > the > > patch is not required for these. At the same time both the older and > > the > > later model have the same vendor- and product-ID, but they both work > > with the patched driver. > > > > Declaration of the Denso cradles I tested: > > - both models have the same IDs: vendorID 0x076d, productID 0x0006 > > - older model: Denso CU-321 (descriptors not properly set) > > - later model: Denso CU-821 (with proper descriptors) > > > > Your patch is line-wrapped and the tabs stripped out of it, making it > impossible to apply :( > > Can you fix up your email client and resend so that I can apply it? > oops, sorry for that. Once again, hopefully in proper condition this time: Signed-off-by: Bjoern Gerhart <oss@xxxxxxxxxxx> --- drivers/usb/class/cdc-acm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 546a17e..d5a4140 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -1654,6 +1654,8 @@ static int acm_reset_resume(struct usb_interface *intf) static const struct usb_device_id acm_ids[] = { /* quirky and broken devices */ + { USB_DEVICE(0x076d, 0x0006), /* Denso Cradle CU-321 */ + .driver_info = NO_UNION_NORMAL, },/* has no union descriptor */ { USB_DEVICE(0x17ef, 0x7000), /* Lenovo USB modem */ .driver_info = NO_UNION_NORMAL, },/* has no union descriptor */ { USB_DEVICE(0x0870, 0x0001), /* Metricom GS Modem */ -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html