Re: [PATCH 04/13] usb: host: uhci: use new USB_RESUME_TIMEOUT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 13 Feb 2015, Felipe Balbi wrote:

> Make sure we're using the new macro, so our
> resume signaling will always pass certification.
> 
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> ---
>  drivers/usb/host/uhci-hub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/uhci-hub.c b/drivers/usb/host/uhci-hub.c
> index 93e17b12fb33..fd809e2cace1 100644
> --- a/drivers/usb/host/uhci-hub.c
> +++ b/drivers/usb/host/uhci-hub.c
> @@ -165,7 +165,7 @@ static void uhci_check_ports(struct uhci_hcd *uhci)
>  				/* Port received a wakeup request */
>  				set_bit(port, &uhci->resuming_ports);
>  				uhci->ports_timeout = jiffies +
> -						msecs_to_jiffies(25);
> +					msecs_to_jiffies(USB_RESUME_TIMEOUT);
>  				usb_hcd_start_port_resume(
>  						&uhci_to_hcd(uhci)->self, port);

You missed a second occurrence in uhci_hub_control():

				else
					/* USB v2.0 7.1.7.7 */
					uhci->ports_timeout = jiffies +
						msecs_to_jiffies(20);

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux