Re: usb: gadget: configfs: OS Extended Compatibility descriptors support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 13.02.2015 o 09:06, Dan Carpenter pisze:
Hello Andrzej Pietrasiewicz,


Hello Dan,

Thank you for finding the problem.

The patch da4243145fb1: "usb: gadget: configfs: OS Extended
Compatibility descriptors support" from May 8, 2014, leads to the
following Smatch warning:

	drivers/usb/gadget/configfs.c:1195 interf_grp_sub_compatible_id_store()
	error: buffer overflow 'desc->ext_compat_id' 16 <= 16


<snip>


Then we are putting the NULL terminator one space beyond the end of the
array.  ->ext_compat_id is set in rndis_alloc_inst().

This is not a false postive, but I'm not positive how we should fix it.


I know how to fix it and will do it soon.

AP

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux