On Mon, Feb 09, 2015 at 02:59:12PM +0800, Peter Hung wrote: > Hello, > > Sergei Shtylyov 於 2015/2/6 下午 08:21 寫道: > >> We extract TIOCGSERIAL section in f81232_ioctl() to > >> f81232_get_serial_info() > >> to make it clarify > > > > You're also changing 'ser.baud_rate' from 460800 to 115200. And > > explicitly overriding some previously initialized to 0 fields. > > F81232 max baudrate is only 115200bps, so I set it for > 1.8432MHz/16 = 115200. > > We had add some closing time referenced from serial_core.c. The default > value is: > > port->close_delay = HZ / 2; /* .5 seconds */ > port->closing_wait = 30 * HZ;/* 30 seconds */ > > We had increasing close_delay about 10x to > > port->close_delay = 5 * HZ ; You're never changing anything, you're just reporting an incorrect value to userspace here. The value you should be returning is jiffies_to_msecs(port->port.closing_wait) / 10, unless the value is ASYNC_CLOSING_WAIT_NONE in which case you simply return that, and similarly for close_delay. > >> The f81232_set_mctrl() replace set_control_lines() to do MCR control > >> so we clean-up the set_control_lines() function. > > > > I don't see where are you doing this... > > > > This text is my patch V5 5/8 second section. I had wrong operation of > copy & paste. It's doesn't need for this patch, sorry for it. Make sure to update the commit log for the next revision so that it describes what you actually do. I will probably not have time to review this version this week I'm afraid. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
