On Tue, Feb 03, 2015 at 11:15:34PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 02/03/2015 07:08 PM, Andy Shevchenko wrote:
>
> >This is a follow up to the previously submitted commit cefa9a31a5f0 (ehci-pci:
> >disable for Intel MID platforms).
>
> >It includes the following changes:
> >- table and function are renamed to reflect this is not only about ChipIdea
> >- ChipIdea PCI driver (ci_hdrc_pci.c) gets the comment about the table in
> > ehci-pci.c
> >- MIPS IDs removed from the list since it was discovered and tested on Intel
> > MID platforms
>
> >Reviewed-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>
> >Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> [...]
> >diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> >index 9652021..2a5d2fd 100644
> >--- a/drivers/usb/host/ehci-pci.c
> >+++ b/drivers/usb/host/ehci-pci.c
> >@@ -42,18 +42,22 @@ static inline bool is_intel_quark_x1000(struct pci_dev *pdev)
> > pdev->device == PCI_DEVICE_ID_INTEL_QUARK_X1000_SOC;
> > }
> >
> >-static const struct pci_device_id ci_hdrc_pci_id_table[] = {
> >- { PCI_DEVICE(0x153F, 0x1004), },
> >- { PCI_DEVICE(0x153F, 0x1006), },
> >+/*
> >+ * This is the list of PCI IDs for the devices that have EHCI USB class and
> >+ * specific drivers for that. One of the example is a ChipIdea device installed
> >+ * on some Intel MID platforms.
> >+ */
> >+static const struct pci_device_id bypass_pci_id_table[] = {
> >+ /* ChipIdea on Intel MID platform */
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0811), },
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829), },
> > { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006), },
>
> I'd suggest using PCI_VDEVICE() here instead.
Not a big deal.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
