Hi Felipe, On Sun, Feb 1, 2015 at 3:37 PM, Felipe Balbi <balbi@xxxxxx> wrote: > I like this, very much. Two comments though. We requested the gpio with > _optional(), and NULL is a valid gpio_desc, this if (nop->gpiod_reset) > is unnecessary. And also, since we don't have anymore the assert But if the reset-gpios property is not present in the dts, then nop->gpiod_reset is NULL, and it is better not to call 'gpiod_direction_output(nop->gpiod_reset, 1)' in this case, right? > argument, we should rename nop_reset_set() to nop_reset. Agreed, will change it in v2. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
