Re: [PATCH 1/3] usb: gadget: function: phonet: balance usb_ep_disable calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Feb 03, 2015 at 04:31:51PM +0100, Pali Rohár wrote:
> On Tuesday 03 February 2015 00:15:19 Felipe Balbi wrote:
> > f_phonet's ->set_alt() method will call usb_ep_disable()
> > potentially on an endpoint which is already disabled. That's
> > something the gadget/function driver must guarantee that it's
> > always balanced.
> > 
> > In order to balance the calls, just make sure the endpoint
> > was enabled before by means of checking the validity of
> > driver_data.
> > 
> > Reported-by: Pali Rohár <pali.rohar@xxxxxxxxx>
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > ---
> 
> Your patches cause that kernel does not print any error message to
> n900 screen anymore and reboot device in 10 seconds. I did not loaded
> any external modules.
> 
> In qemu I see this crash in early boot:

alright, so n900's working fine. I'll wait until you debug qemu a little
more, thank you

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux