Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
> On some Intel MID platforms the ChipIdea USB controller is used. The EHCI PCI
> is in conflict with the proper driver. The patch makes ehci-pci to be ignored
> in favour of ChipIdea controller.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/host/ehci-pci.c | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index 851006a..9652021 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -42,6 +42,20 @@ static inline bool is_intel_quark_x1000(struct pci_dev *pdev)
> pdev->device == PCI_DEVICE_ID_INTEL_QUARK_X1000_SOC;
> }
>
> +static const struct pci_device_id ci_hdrc_pci_id_table[] = {
You forgot to add a comment explaining what does this do and why.
> + { PCI_DEVICE(0x153F, 0x1004), },
> + { PCI_DEVICE(0x153F, 0x1006), },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0811), },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x0829), },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0xe006), },
> + {}
> +};
All other concerns aside, who's going to maintain this table?
At the very least, call it "bypass" or "blacklist", not "ci" and only
include ids that you actually care about. And possibly document this
somewhere.
Regards,
--
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
