On Wed, Jan 28, 2015 at 07:03:17PM +0200, Andy Shevchenko wrote:
> The patch joins the string literals for happy debugging. There is no functional
> change.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/host/pci-quirks.c | 55 ++++++++++++++++++++++---------------------
> 1 file changed, 28 insertions(+), 27 deletions(-)
>
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index ce63646..98f2f0b 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -503,23 +503,20 @@ int uhci_check_and_reset_hc(struct pci_dev *pdev, unsigned long base)
> */
> pci_read_config_word(pdev, UHCI_USBLEGSUP, &legsup);
> if (legsup & ~(UHCI_USBLEGSUP_RO | UHCI_USBLEGSUP_RWC)) {
> - dev_dbg(&pdev->dev, "%s: legsup = 0x%04x\n",
> - __func__, legsup);
> + dev_dbg(&pdev->dev, "%s: legsup = 0x%04x\n", __func__, legsup);
That's not joining any string literal together, so your subject is quite
odd.
> goto reset_needed;
> }
>
> cmd = inw(base + UHCI_USBCMD);
> if ((cmd & UHCI_USBCMD_RUN) || !(cmd & UHCI_USBCMD_CONFIGURE) ||
> !(cmd & UHCI_USBCMD_EGSM)) {
> - dev_dbg(&pdev->dev, "%s: cmd = 0x%04x\n",
> - __func__, cmd);
> + dev_dbg(&pdev->dev, "%s: cmd = 0x%04x\n", __func__, cmd);
Same here.
> goto reset_needed;
> }
>
> intr = inw(base + UHCI_USBINTR);
> if (intr & (~UHCI_USBINTR_RESUME)) {
> - dev_dbg(&pdev->dev, "%s: intr = 0x%04x\n",
> - __func__, intr);
> + dev_dbg(&pdev->dev, "%s: intr = 0x%04x\n", __func__, intr);
And here.
the others look ok, care to redo this?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
