On Wed, Jan 28, 2015 at 08:18:30AM +0100, Robert Baldyga wrote: > On 01/27/2015 04:42 PM, Felipe Balbi wrote: > > On Mon, Jan 05, 2015 at 10:31:35AM +0100, Robert Baldyga wrote: > >> This patch fixes in simpler way the bug described in [1] and [2]. It > >> looks like DWC2 is the only UDC driver that doesn't force usb requests > >> to complete in ep_disable() function. This causes described problem, > >> because we have no guarantee that all requests will be completed before > >> unbind of usb function. > >> > >> To fix this problem we force all requests of disabled endpoint to complete. > >> Also currently running request is not handled. This allowed to simplify > >> code of kill_all_requests() function, because 'force' parameter is always > >> set to true, so we don't need it anymore. > >> > >> In s3c_hsotg_rx_data() we change function used to print message when active > >> request is NULL from dev_warn() to dev_dbg(), because such situation is > >> harmless for driver and now it can take place during normal endpoint > >> disabling. > >> > >> [1] https://lkml.org/lkml/2014/12/9/283 > >> [2] https://lkml.org/lkml/2014/12/12/360 > >> > >> Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx> > > > > this fails to apply: > > > > checking file drivers/usb/dwc2/gadget.c > > Hunk #1 succeeded at 2602 (offset 35 lines). > > Hunk #2 FAILED at 2588. > > Hunk #3 succeeded at 2645 (offset 36 lines). > > Hunk #4 FAILED at 2924. > > 2 out of 4 hunks FAILED > > > > Isn't this patch already in linux-next? I see it's also in your 'next' > branch. if it's there, good. -- balbi
Attachment:
signature.asc
Description: Digital signature
