Re: [PATCH 20/23] musb_virthub: use HUB_CHAR_*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 25, 2015 at 07:51:49PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 01/19/2015 01:57 AM, Sergei Shtylyov wrote:
> 
> >Fix  using the  bare numbers to set the 'wHubCharacteristics' field of the Hub
> >Descriptor while the values are #define'd in <linux/usb/ch11.h>.
> 
> >Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> 
> >---
> >  drivers/usb/musb/musb_virthub.c |    7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> >Index: usb/drivers/usb/musb/musb_virthub.c
> >===================================================================
> >--- usb.orig/drivers/usb/musb/musb_virthub.c
> >+++ usb/drivers/usb/musb/musb_virthub.c
> >@@ -349,9 +349,10 @@ int musb_hub_control(
> >  		desc->bDescriptorType = 0x29;
> >  		desc->bNbrPorts = 1;
> >  		desc->wHubCharacteristics = cpu_to_le16(
> >-				  0x0001	/* per-port power switching */
> >-				| 0x0010	/* no overcurrent reporting */
> >-				);
> >+			  HUB_CHAR_INDV_PORT_LPSM /* per-port power switching */
> >+
> 
>    Ugh, don't know how this empty line sneaked into the patch. Greg, could
> you please drop it?

fixed

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux