On Tue, Jan 27, 2015 at 01:09:25PM +0200, Heikki Krogerus wrote: > > look at your patch again. In case DWC3_ULPI isn't enabled, this file > > won't be linked at all. You're using stubs, so taht's fine. > > > > In case it _is_ enabled, you're breaking out early if you can't register > > ulpi interface, meaning you're exitting probe() (which, in fact, seems > > wrong as I want to be able to run dwc3 with ULPI enabled on a platform > > that was configured with ULPI+UTMI, but uses UTMI PHY). > > > > I still think this patch won't work in all cases. > > OK. So in case of ULPI+UTMI we'll try the ulpi interface, and if it > fails, fall back to UTMI. Or can we use some other method to determine > to which interface the PHY is really attached to in that case? I think we would need a phy_interface_sel pdata/DT binding for those cases. It should be optional and probably only needed for a few odd devices. -- balbi
Attachment:
signature.asc
Description: Digital signature
