Re: Boot regression on Versatile Express TC2 after commit b2b49ccbdd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2015-01-23 at 17:08 +0000, Nicolas Pitre wrote:
> On Fri, 23 Jan 2015, Pawel Moll wrote:
> 
> > On Thu, 2015-01-22 at 21:11 +0000, Rafael J. Wysocki wrote:
> > > > I'll work on it when I have some spare time.  Of course, it would be 
> > > > better if somebody could add the proper wakeup-detect code to the 
> > > > isp1760-hcd driver...
> > > 
> > > Yes, it would.
> > 
> > Whether it's a hack or no - I don't know, but it makes my board detect
> > USB devices again with v3.19-rc5, without any extra kernel parameters:
> > 
> > 8<---------------
> > diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
> > index 395649f..92a8297 100644
> > --- a/drivers/usb/host/isp1760-hcd.c
> > +++ b/drivers/usb/host/isp1760-hcd.c
> > @@ -2250,7 +2250,6 @@ struct usb_hcd *isp1760_register(phys_addr_t res_start, resource_size_t res_len,
> >  	ret = usb_add_hcd(hcd, irq, irqflags);
> >  	if (ret)
> >  		goto err_unmap;
> > -	device_wakeup_enable(hcd->self.controller);
> >  
> >  	return hcd;
> > 8<---------------
> > 
> > Care to give it a go, Nico?
> 
> Doesn't work for me. I still need usbcore.autosuspend=-1 on the kernel 
> cmdline for USB to work.

Interesting. Tried again and this time didn't work either... Will have a
look again on Monday and see if it changes again :-) (and in the
meantime try to think what has changed).

Pawel

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux