On Fri, Jan 23, 2015 at 10:23:48AM +0200, Heikki Krogerus wrote: > On Thu, Jan 22, 2015 at 02:51:24PM -0600, Felipe Balbi wrote: > > On Wed, Jan 21, 2015 at 01:39:58PM +0200, Heikki Krogerus wrote: > > > Hi, > > > > > > On Wed, Jan 21, 2015 at 11:17:49AM +0200, Heikki Krogerus wrote: > > > > On Tue, Jan 20, 2015 at 09:45:39AM -0600, Felipe Balbi wrote: > > > > > > diff --git a/drivers/phy/ulpi/tusb1210.c b/drivers/phy/ulpi/tusb1210.c > > > > > > new file mode 100644 > > > > > > index 0000000..ac77f98 > > > > > > --- /dev/null > > > > > > +++ b/drivers/phy/ulpi/tusb1210.c > > > > > > > > > > do you really need this extra ulpi directory ? > > > > > > > > > > I wonder if phy-tusb1210.c as a name would be enough. > > > > > > > > IMO grouping the ULPI PHY drivers and other ULPI bus code into > > > > separate folder from the start is the right thing to do. > > > > > > A correction to this comment. I probable don't need this folder. Like > > > you said, phy-tusb1210.c should be enough.. > > > > > > <snip> > > > > > > > > In fact, we might decide to add an entire ULPI bus, eventually, though > > > > > I'm still considering if there's any benefit to that. > > > > > > > > I don't think I understand this comment? ULPI bus is what I'm > > > > introducing in this set (the first patch in it)? > > > > > > ..I talked with Alex about this :). So I think the bus belongs under > > > drivers/usb/core/ instead of driver/phy/. It's not really tied to the > > > Generic PHY framework in any way, but ULPI is of course USB specific. > > > > right, maybe drivers/usb/ulpi or maybe drivers/ulpi, and have > > phy-tusb1201 register under that ulpi_bus_type instead of > > platform_bus_type, but still use drivers/phy to register itself a phy > > provider ;-) > > So just for the record: This driver does not register under > platform_bus_type bus but instead already under ulpi_bus_type. hah! :-) > I'll prepare new version out of these today and try to figure out > proper place for the code (maybe drivers/usb/ulpi?). drivers/phy is fine, it is a phy driver anyway... I just should've read it to see there was a ulpi_bus_type :-) -- balbi
Attachment:
signature.asc
Description: Digital signature
