Re: [PATCH 22/23] usbip: vhci_hcd: use HUB_CHAR_*

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 19, 2015 at 1:00 AM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> Fix  using the  bare number  to set the 'wHubCharacteristics' field of the Hub
> Descriptor while the values are #define'd in <linux/usb/ch11.h>.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> ---
>  drivers/usb/usbip/vhci_hcd.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: usb/drivers/usb/usbip/vhci_hcd.c
> ===================================================================
> --- usb.orig/drivers/usb/usbip/vhci_hcd.c
> +++ usb/drivers/usb/usbip/vhci_hcd.c
> @@ -218,7 +218,8 @@ static inline void hub_descriptor(struct
>         memset(desc, 0, sizeof(*desc));
>         desc->bDescriptorType = 0x29;
>         desc->bDescLength = 9;
> -       desc->wHubCharacteristics = (__constant_cpu_to_le16(0x0001));
> +       desc->wHubCharacteristics = __constant_cpu_to_le16(
> +               HUB_CHAR_INDV_PORT_LPSM | HUB_CHAR_COMMON_OCPM);
>         desc->bNbrPorts = VHCI_NPORTS;
>         desc->u.hs.DeviceRemovable[0] = 0xff;
>         desc->u.hs.DeviceRemovable[1] = 0xff;
>

Looks good.

Thanks,
Valentina
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux