Hello, On Fri, Jan 23, 2015 at 09:59:58AM +0100, Nicolas Ferre wrote: > Le 23/01/2015 08:43, Jean-Christophe PLAGNIOL-VILLARD a écrit : > > > On Jan 23, 2015, at 12:56 AM, Sylvain Rochet <sylvain.rochet@xxxxxxxxxxxx> wrote: > > > + irq_set_status_flags(gpio_to_irq(udc->vbus_pin), > > > + IRQ_NOAUTOEN); > > > > not happy about still using the broken gpio_to_irq API > > > > Linus can pass the IRQ via board file? > > > > and via DT we can use IRQ directly Although I agree on the general principle, this driver is also used by non-DT boards. I have concerns at least for at32ap700x-based boards which use this driver and are non-DT. The suggested change requires changing platform data of at32ap700x in such a way we may break it in my opinion. > Absolutely not the topic of this patch series. > Maybe the subject of another patch later? Indeed. This series is only about PM support, harmless rework, or necessary rework for PM. Changing the way we acquire the IRQ is not harmless, this should be checked carefully for DT and particularly non-DT boards. Sylvain -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
