On Tue, Jan 20, 2015 at 09:29:04PM +0200, Laurent Pinchart wrote: > Hi Felipe, > > On Friday 09 January 2015 11:34:25 Felipe Balbi wrote: > > On Fri, Jan 09, 2015 at 11:30:31AM -0600, Felipe Balbi wrote: > > >> This patch set adds UDC support to the isp1760 driver, to be used with > > >> the ISP1761 dual-role USB controller. > > >> > > >> The first 17 patches rework the isp1760 driver to prepare it for UDC > > >> support. In particular they removes the direct HCD dependencies from > > >> the glue code (01/20 to 04/20), creates core initialization code shared > > >> by the HCD and UDC (15/20) and move common initialization code to the > > >> core (16/20 to 17/20). > > >> > > >> Patch 18/20 adds UDC support, and patches 19/20 and 20/20 move the > > >> driver to drivers/usb/isp1760/ and make HCD support optional. > > >> > > >> The ISP1761 has three USB ports, with port 1 configurable in host or > > >> peripheral mode with OTG support, and ports 2 and 3 supporting host > > >> mode only. OTG support is not implemented yet, port 1 can thus be > > >> configured in host or peripheral mode only. > > >> > > >> The UDC driver has been successfully tested with the g_zero and > > >> g_mass_storage gadgets. > > >> > > >> Global changes compared to v2: > > >> > > >> - Rebase on top of Felipe's testing/next branch > > >> - Drop patches that have been merged already > > >> - Add patch 19/20 and 20/20 > > >> > > >> Global changes compared to v1: > > >> > > >> - Replace GPIO request move by patch 01/22 > > >> - Split PORT1 configuration to separate patch > > >> - Drop the shutdown implementation patch > > >> - Add patches 02/22, 04/22, 05/22, 13/22, 14/22 > > >> > > >> See individual patches for patch-specific changes. > > > > > > with this set I started getting: > > > > > > In file included from drivers/usb/isp1760/isp1760-core.h:22:0, > > > > > > from drivers/usb/isp1760/isp1760-core.c:24: > > > drivers/usb/isp1760/isp1760-udc.h:65:5: warning: "CONFIG_USB_ISP1761_UDC" > > > is not defined [-Wundef] drivers/usb/isp1760/isp1760-udc.h:90:5: warning: > > > "CONFIG_USB_ISP1761_UDC" is not defined [-Wundef] > > > > > > I have now dropped this series from my testing/next > > > > btw, I've dropped the entire series, even the ones which were applied > > before. Please rebase and make sure each patch builds fine without > > warnings or build errors. > > Sorry about that. I forgot to update drivers/usb/host/Makefile, and the build > breakage went unnoticed as the isp1760 object files were still available in > that directory. I'm fixing the issue and I'll resubmit the patches shortly. cool, thanks -- balbi
Attachment:
signature.asc
Description: Digital signature
