Re: [PATCH] usb: misc: Driver for Yepkit YKUSH switchable hub

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 19, 2015 at 08:32:26PM +0100, Kristian Evensen wrote:
> The Yepkit YKUSH <https://www.yepkit.com/products/ykush> is a three-port
> switchable USB hub. In addition the to actual hub device, an HID device is
> exported (VID 0x04D8 PID 0x0042). By sending specific commands to the HID
> device, it is possible to power up/down the three ports separately or all ports
> together. Commands 0x01-0x03 is used to power down ports 1-3, while 0x0A is used
> to power down all ports. In order to power up a port (or all ports), the command
> is OR'd with 0x10.

That's great, and the hid parts of the patch makes sense, keeping the
HID driver from binding to it, but for the rest, shouldn't that just be
a simple userspace program instead?  We don't like to add kernel drivers
that can be done in userspace, and using usbfs/libusb should be really
simple for this device from what the driver looks like.

So, care to slim down the patch a bunch and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux