On Fri, Jan 16, 2015 at 01:44:44PM +0100, Andrzej Pietrasiewicz wrote: > W dniu 16.01.2015 o 13:12, Dan Carpenter pisze: > >Oh, yeah. You're right. I should have been more careful and I should > >have seen that. Sorry. But the problem is the original code is still a > >bit buggy. > > > >We call: > > > > data = kzalloc(); > > > >Inside __uvcg_fill_strm() we do "data += something;" > > > > kfree(data); > > > >We should save the orignal data pointer so that we can free it > >correctly at the end in uvcg_streaming_class_allow_link(). > > > Yeah, right. Thank you for spotting this. The kfree() is called > only if __uvcg_fill_strm() fails, though. But of course this needs > to be fixed. so, should I wait for another version of $subject ? -- balbi
Attachment:
signature.asc
Description: Digital signature
