Re: [PATCH v3 3/3] usb: udc: add usb_udc_activation_handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 16, 2015 at 11:11:56AM -0500, Alan Stern wrote:
> On Fri, 16 Jan 2015, Peter Chen wrote:
> 
> > During this API, the deactivation count will be update, and it
> > will try to connect or disconnect gadget. It can be used to
> > enable functions for gadget.
> > 
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > ---
> >  drivers/usb/gadget/udc/udc-core.c | 28 +++++++++++++++++++++++++++-
> >  include/linux/usb/gadget.h        |  5 +++++
> >  2 files changed, 32 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/gadget/udc/udc-core.c b/drivers/usb/gadget/udc/udc-core.c
> > index 9396a86..86d4d19 100644
> > --- a/drivers/usb/gadget/udc/udc-core.c
> > +++ b/drivers/usb/gadget/udc/udc-core.c
> > @@ -37,6 +37,7 @@
> >   * @list - for use by the udc class driver
> >   * @vbus - for udcs who care about vbus status, this value is real vbus status;
> >   * for udcs who do not care about vbus status, this value is always true
> > + * @deactivations - the deactivation count to connect or disconnect gadget
> 
> How will this field get initialized?
> 

Thanks, Alan.

The function driver will be deactivated default, the patch likes below:

http://permalink.gmane.org/gmane.linux.usb.general/112747

(Call usb_udc_activation_handler instead of usb_function_deactivate)

The function driver can activate itself at the .bind or on the demand.

http://permalink.gmane.org/gmane.linux.usb.general/112748
http://permalink.gmane.org/gmane.linux.usb.general/112752

> Aside from that question, patches 2 and 3 look good.
> 
> Alan Stern
> 

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux