On Fri, Dec 05, 2014 at 02:48:19PM +0000, Mark Knibbs wrote:
>
> I recently posted a patch ("storage: Add quirk for another SCM-based
> USB-SCSI converter") to add a quirk for the converter with ID 04E6:000F,
> which is listed along with 04E6:000B in the Windows INF file for the
> Startech ICUSBSCSI2 as "eUSB SCSI Adapter (Bus Powered)".
>
> The already-present quirk for 04E6:000B has USB_SC_SCSI/USB_PR_BULK, not
> USB_SC_DEVICE/USB_PR_DEVICE. Change the 04E6:000F quirk to match that.
>
> Signed-off-by: Mark Knibbs <markk@xxxxxxxxxxx>
>
> ---
>
> While I don't have one to check, later SCM converters probably use
> vendor-specific class and protocol, thus specifying USB_SC_SCSI/USB_PR_BULK
> is necessary. Some speculation as to the reason for the difference...
>
> I'm not sure whether the change was for all later products, or is related
> to the later products being bus-powered. Windows 98 was the current
> mainstream OS when the eUSCSI converter was first introduced. That OS
> didn't ship with a USB mass storage driver, thus in order to use the
> converter the SCM driver had to be installed.
>
> Later Windows 2000 was released, which included a USB mass storage driver.
> If the user were to connect the converter before installing the SCM driver,
> Windows would install its default mass storage driver which only works with
> the SCSI device at ID 0. Perhaps SCM changed to a vendor-specific class/
> protocol to prevent the Windows generic driver binding to it, and reduce
> driver-related technical support issues?
>
> Patch is based on 3.18-rc7.
>
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 11c7a96..bfc4a6a 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -507,7 +507,7 @@ UNUSUAL_DEV( 0x04e6, 0x000c, 0x0100, 0x0100,
> UNUSUAL_DEV( 0x04e6, 0x000f, 0x0000, 0x9999,
> "SCM Microsystems",
> "eUSB SCSI Adapter (Bus Powered)",
> - USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_euscsi_init,
> + USB_SC_SCSI, USB_PR_BULK, usb_stor_euscsi_init,
> US_FL_SCM_MULT_TARG ),
The whitespace here is all messed up (all spaces), and prevents this
patch from being applied :(
Can you please fix that up and resend?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
