Re: [PATCH 2/3] usb: gadget: uac1: struct gaudio is useless for struct f_uac1_opts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 1, 2014 at 4:09 PM, Peter Chen <peter.chen@xxxxxxxxxxxxx> wrote:
> Since we call gaudio_cleanup at f_audio_free, the f_uac1_opts
> doesn't need to use gaudio any more.
>
> Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> ---
>  drivers/usb/gadget/function/f_uac1.c | 1 -
>  drivers/usb/gadget/function/u_uac1.h | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/function/f_uac1.c
> index e971584..0827731 100644
> --- a/drivers/usb/gadget/function/f_uac1.c
> +++ b/drivers/usb/gadget/function/f_uac1.c
> @@ -669,7 +669,6 @@ f_audio_bind(struct usb_configuration *c, struct usb_function *f)
>
>         audio_opts = container_of(f->fi, struct f_uac1_opts, func_inst);
>         audio->card.gadget = c->cdev->gadget;
> -       audio_opts->card = &audio->card;
>         /* set up ASLA audio devices */
>         if (!audio_opts->bound) {
>                 status = gaudio_setup(&audio->card);
> diff --git a/drivers/usb/gadget/function/u_uac1.h b/drivers/usb/gadget/function/u_uac1.h
> index f8b17fe..fe386df 100644
> --- a/drivers/usb/gadget/function/u_uac1.h
> +++ b/drivers/usb/gadget/function/u_uac1.h
> @@ -70,7 +70,6 @@ struct f_uac1_opts {
>         unsigned                        fn_play_alloc:1;
>         unsigned                        fn_cap_alloc:1;
>         unsigned                        fn_cntl_alloc:1;
> -       struct gaudio                   *card;
>         struct mutex                    lock;
>         int                             refcnt;
>  };
> --
> 1.9.1
>

Hi Felipe,

I see Patch 1/3 is in your testing/fixes, but Patch 2/3 and Patch 3/3
are not at your testing/next.
Would you have plan to queue them?


-- 
BR,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux