On Thu, Jan 08, 2015 at 06:32:27PM +0200, Grygorii.Strashko@xxxxxxxxxx wrote:
> Hi,
>
> On 01/07/2015 06:41 AM, Olof Johansson wrote:
> > On Tue, Jan 6, 2015 at 7:45 AM, Maxime Ripard
> > <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> >> Commit 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error on
> >> failure") actually broke the deferred probing mechanism, since it now returns
> >> EPROBE_DEFER only when the try_module_get call fails, but not when the phy
> >> lookup does.
> >>
> >> All the other similar functions seem to return ENODEV when try_module_get
> >> fails, and the error code of either __usb_find_phy or __of_usb_find_phy
> >> otherwise.
> >>
> >> In order to have a consistent behaviour, and a meaningful EPROBE_DEFER, always
> >> return EPROBE_DEFER when __(of_)usb_find_phy fails to look up the requested
> >> phy, that will be propagated by the caller, and ENODEV if try_module_get fails.
> >>
> >
> > Fixes: 1290a958d48e ("usb: phy: propagate __of_usb_find_phy()'s error
> > on failure")
> >
> >> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> >
> > This also fixes USB on tegra/trimslice here.
> >
> > Tested-by: Olof Johansson <olof@xxxxxxxxx>
> >
> > Given that the regression went in during 3.19 merge window, this
> > should go in as a fix during -rc, please.
>
> 1) Pls note, there is a duplication patch https://www.mail-archive.com/linux-usb@xxxxxxxxxxxxxxx/msg53893.html
> but this one is more correct as for me.
>
> 2) This patch fixes USB regression on Keystone 2, so
>
> Tested-by: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx>
Are we asking that I drop Thierry's Patch or just apply the other hunks?
--
balbi
Attachment:
signature.asc
Description: Digital signature
