Paul Bonser wrote:
> On 01/06/2015 07:39 AM, Clemens Ladisch wrote:
>> Paul Bonser wrote:
>>> This device incorrectly reports its bInterfaceClass as 255, when it
>>> should really be 1 (USB_CLASS_AUDIO).
>>>
>>> +++ b/sound/usb/quirks-table.h
>>> +{
>>> + /* Akai MPC Element */
>>> + USB_DEVICE(0x09e8, 0x0021),
>>> + .bInterfaceClass = USB_CLASS_AUDIO,
>>> +},
>>
>> This is not a correct usb_device_id entry.
>
> I based it on an existing entry in the same file:
>
> /* KeithMcMillen Stringport */
> {
> USB_DEVICE(0x1f38, 0x0001),
> .bInterfaceClass = USB_CLASS_AUDIO,
> },
>
> It built with no complaints and functioned as expected (showed up as a
> MIDI device and sent/recived commands via ALSA MIDI whereas before it
> didn't).
The bInterfaceClass value has no effect; these entries happen to work
only by chance.
All entries are supposed to define some quirk(s), like this:
{
/* Akai MPC Element */
USB_DEVICE(0x09e8, 0x0021),
.driver_info = (unsigned long) & (const struct snd_usb_audio_quirk) {
.ifnum = 1,
.type = QUIRK_MIDI_STANDARD_INTERFACE
}
},
> I should have sent he email to you (since you're the USB MIDI
> maintainer), and CCd the linux-kernel@xxxxxxxxxxxxxxx and
> linux-usb@xxxxxxxxxxxxxxx lists?
The only matching entry for sound/usb/quirks-table.h in the MAINTAINERS
file tells you to send to perex, tiwai, and alsa-devel.
> Once we've worked out the proper format for this entry, should I re-send
> it following that pattern?
Yes.
Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
