On Mon, Jan 5, 2015 at 11:06 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > Am Montag, den 05.01.2015, 10:12 -0200 schrieb Fabio Estevam: >> Hi Lucas, >> >> On Mon, Jan 5, 2015 at 9:02 AM, Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: >> > Some controllers need to have external power supplied before toggling >> > the internal PORT_POWER bit. >> > >> > Fixes: 11a7e5940514 (usb: ehci: add ehci_port_power interface) on i.MX51 >> > where the controller would hang the machine when trying to enable PORT_POWER. >> >> I tested your patch and the hang does not happen anymore, but the USB >> host port on my imx51-babbage is no longer functional: attaching a USB >> thumb on the host port is not detected. >> >> If I apply the following patch then I am able to get USB host port >> functional again: >> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-December/310705.html > > Urgh, I looked at this again and it's a complete mess. According to the > schematics I have the "reg_usbh1_vbus" isn't a regulator, but a ULPI PHY > reset GPIO. So the devicetree description is completely wrong here. > Sorry to say, but git blame points to you. Yes, I know. Besides that, there is also the problem that we currently don't have a way for providing a reset for USB hub via dt. > Marking the regulator as always-on may fix it for you, but that doesn't > guarantee proper reset of the PHY if the bootloader already set it up. > This really needs a separate PHY reset GPIO property to fix it properly, > same thing as is done tegra20-usb-phy. I will try to provide a proper fix for imx51-babbage. Regards, Fabio Estevam > > Regards, > Lucas > -- > Pengutronix e.K. | Lucas Stach | > Industrial Linux Solutions | http://www.pengutronix.de/ | > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
