Re: [PATCH] usb-storage/SCSI: blacklist FUA on JMicron 152d:2566 USB-SATA controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 29 Dec 2014, Dmitry Nezhevenko wrote:

> It looks like FUA support is broken on JMicron 152d:2566 bridge:
> 
> [223159.885704] sd 7:0:0:0: [sdc] Write Protect is off
> [223159.885706] sd 7:0:0:0: [sdc] Mode Sense: 47 00 10 08
> [223159.885942] sd 7:0:0:0: [sdc] Write cache: enabled, read cache: enabled, supports DPO and FUA
> 
> [223283.691677] sd 7:0:0:0: [sdc]
> [223283.691680] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE
> [223283.691681] sd 7:0:0:0: [sdc]
> [223283.691682] Sense Key : Illegal Request [current]
> [223283.691684] sd 7:0:0:0: [sdc]
> [223283.691685] Add. Sense: Invalid field in cdb
> [223283.691686] sd 7:0:0:0: [sdc] CDB:
> [223283.691687] Write(10): 2a 08 15 d0 83 0d 00 00 01 00
> [223283.691690] blk_update_request: critical target error, dev sdc, sector 2927892584
> 
> This patch adds blacklist flag so that sd will not use FUA
> 
> Signed-off-by: Dmitry Nezhevenko <dion@xxxxxxxxxxx>
> Cc: Phil Dibowitz <phil@xxxxxxxx>
> Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/usb/storage/unusual_devs.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 11c7a96..932f8fe 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1986,6 +1986,13 @@ UNUSUAL_DEV(  0x152d, 0x0567, 0x0114, 0x0114,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_BROKEN_FUA ),
>  
> +/* Reported by Dmitry Nezhevenko <dion@xxxxxxxxxxx> */
> +UNUSUAL_DEV(  0x152d, 0x2566, 0x0114, 0x0114,
> +		"JMicron",
> +		"USB to ATA/ATAPI Bridge",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_BROKEN_FUA ),
> +
>  /* Reported by Alexandre Oliva <oliva@xxxxxxxxxxxxxxxxx>
>   * JMicron responds to USN and several other SCSI ioctls with a
>   * residue that causes subsequent I/O requests to fail.  */

These entries should be sorted by vendor ID, then product ID.  Product 
ID 0x2566 comes after 0x2329, not before.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux