RE: [PATCH 0/3] usb: chipidea: add one errata for revision 2.40a

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 
> On 12/18/2014 06:47 PM, Matthieu CASTET wrote:
> > Le Wed, 17 Dec 2014 20:40:29 +0800,
> > Peter Chen <peter.chen@xxxxxxxxxxxxx> a écrit :
> >
> >> On Wed, Dec 17, 2014 at 05:31:40PM +0530, Sanchayan Maity wrote:
> >>> On 12/17/2014 02:05 PM, Peter Chen wrote:
> >>>> Hi all,
> >>>>
> >>>> At the first two patches, I add identification registers APIs, we
> >>>> can get controller's revision by using this APIs. Since I don't
> >>>> have enough spec, if there are any errors, tell me.
> >>>>
> >>>> At the third patch, I implement an errata for revision 2.40a, hope
> >>>> it can fix the problem Sanchayan Maity reported.
> >>>>
> >>>> http://www.spinics.net/lists/linux-usb/msg118544.html
> >>>>
> >>>> @Sanchayan, would you please have a test?
> >>>>
> >>>> Peter Chen (3):
> >>>>   usb: chipidea: add identification registers access APIs
> >>>>   usb: chipidea: add chipidea revision information
> >>>>   usb: chipidea: udc: add errata for revision 2.40a
> >>>>
> >>>>  drivers/usb/chipidea/bits.h | 10 +++++++++
> >>>>  drivers/usb/chipidea/ci.h   | 53
> +++++++++++++++++++++++++++++++++++++++++++++
> >>>>  drivers/usb/chipidea/core.c | 23 ++++++++++++++++++--
> >>>> drivers/usb/chipidea/udc.c  | 18 ++++++++++++++-
> >>>>  4 files changed, 101 insertions(+), 3 deletions(-)
> >>>>
> >>>
> >>> Thanks for the patches.
> >>>
> >>> I tested the patches with iperf and tried a few times to be sure.
> >>> The condition is still the same.
> >>>
> >>
> >> Oh, bad luck. Be sure the code I added for 2.40a is ran at your board.
> >>
> >
> > For information we workarounded this errata with the attached patched.
> > It is based on a old version of the driver.
> > We never had time to clean and submit the patch, but it solve the
> > errata in our case.
> >
> >
> > Matthieu
> >
> 
> I came in the morning and saw this patch. Immediately modified it and applied.
> Glad to say that it works. I had iperf running for an hour with no problem and
> 48.7GBytes of transfer at 116MBits/sec :). Going to run a longer 3 hour iperf
> test now, but, I guess it should be fine. I will spin a combination patch of what
> Peter and Matthieu gave me and try sending it by today evening for me,
> before going on vacation.
> 

Please try to see " mEp->qh.ptr->cap |=  QH_ZLT;" in Matthieu's patch is needed or not,
since the QH cap is initialized when the ep is enabled, and it should not be changed.

Peter

> Thanks a lot Matthieu, Peter and Felipe for the inputs and help.
> 
> -Cheers,
> Sanchayan.

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux